Miscellaneous small answer changes #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files with values not just identical to missing value
…272 to avoid deep soil caron in permafrost regions fixing ESCOMP#1460
…oil_decomp_method is None, and otherwise TRUE which means it will normally be true when FATES is on fixing ESCOMP#1465
…COMP#43, we currently just allow it to be true even through the conservation check for methane fails at the first time step of each year
…less if PHS is on or off
…arch for an exact match, this allows non irrigated to always be an option so the test for it can be removed
…ing first for nofail with crop and irrigation true, and if didn't find it try again with the exact match
… SP datasets, while setting it to false for the crop datasets for landuse timeseries
ekluzek
added
the
enhancement
…ATES don't check for crop datasets first, add non vichydro datasets (pointing to the same file) for fsurdat and flanduse_timeseries so that FATES can use those datasets
|
This is now passing all tests as expected on cheyenne. izumi seems to be down, so will test as soon as I can. |
|
izumi is back up, and all tests are now passing on izumi. So this is ready to come in. Just need to do the ChangeLog file. |
|
Some some clm4_5 and clm5_0 tests remain identical. The VIC tests are identical which is expected. Urban single point tests are identical, which seems reasonable. PTSMODE tests are identical, that's expected. NoAnthro test because it doesn't change. There are a few other tests that are identical mostly with Crop as that means it won't change the dataset, and mostly not cold-starts, and mostly short enough.
Cold starts I'm a bit surprised at being identical...
|
|
Also note that the change for GSSHA and GSSUN I thought would apply all the time, seems to only apply part of the time. As such I don't see a change for those two history variables in many cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Change ceta from 450 to 358 for CTSM5.1
Turn Medlyn on for PHS off for clm51 and clm50 (3 dynroot tests will change answers)
Make max CO2 partial pressure consistent
Change surface datasets to only use 78PFT versions (so SP results may change) [except for FATES and vichydro]
Fix GSSUN and GSSHA history variables so now not just missing values
Changes FATES to run with use_nitrif_dentrif=T by defaul;t
Change dynlakes test to methane/use_nitrif_=T
(This will allow use_nitrif and methane flags to be removed)
Specific notes
Contributors other than yourself, if any: @djk2120
CTSM Issues Fixed (include github issue #):
Fixes #1504
Fixes #1503
Fixes #1462
Fixes #1394
Fixes #1460
Fixes #1465
Worked on #1356
Fixes #1496
Are answers expected to change (and if so in what way)? Yes!
Small changes to a few defaults will change answers in most configurations
Any User Interface Changes (namelist or namelist defaults changes)? Changes some defaults
Testing performed, if any: Limited so far, will do regular testing
testing passes as expected on cheyenne